heymlz/hossein-por-shop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor serializers and views for improved readability and performance

Browse Source
This commit is contained in:
Parsa Nazer
2025-11-03 11:51:28 +03:30
parent 6524ae7605
commit c0d787da6a
2 changed files with 124 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/product/views.py
+88 -47
View File
@@ -1,3 +1,5 @@
from .models import ProductModel
from rest_framework import serializers
from django.core.paginator import Paginator
from rest_framework.views import APIView
from .models import *
@@ -29,6 +31,7 @@ from order.models import Cart, CartItem
class AllCategories(APIView):
serializer_class = MainCategorySerializer
authentication_classes = []
@extend_schema(
# parameters=[
# OpenApiParameter(
@@ -49,24 +52,51 @@ class AllCategories(APIView):
# categories = MainCategoryModel.objects.filter(Q(name__icontains=search_query) | Q(slug__icontains=search_query))
# else:
categories = MainCategoryModel.objects.all()
categories_ser = self.serializer_class(instance=categories, many=True, context={'request': request})
categories_ser = self.serializer_class(
instance=categories, many=True, context={'request': request})
return Response(categories_ser.data, status=status.HTTP_200_OK)
class ProductView(APIView):
serializer_class = DynamicProductSerializer
permission_classes = [AllowAny]
# authentication_classes = []
def get(self, request, slug):
product = get_object_or_404(ProductModel, slug=slug)
# Optimize query with select_related and prefetch_related to avoid N+1 queries
product = get_object_or_404(
ProductModel.objects.select_related(
'category', 'category__parent', 'shop')
.prefetch_related(
'variants__product_attributes__attribute_type',
'variants__in_pack_items',
'variants__images',
'variants__details__details',
'variants__details__detail_category',
'related_products__variants__product_attributes',
'related_products__category',
),
slug=slug
)
if request.user.is_authenticated:
cart_obj, _ = Cart.objects.get_or_create(user=request.user)
cart_items = cart_obj.items.all()
cart_items_ser = OrderItemSerailzier(cart_items, many=True, context={'request': request})
product_ser_context = {'request': request, 'view_type': 'instance', 'cart_items': cart_items_ser.data}
# Optimize cart items query - prefetch all related data
cart_items = cart_obj.items.select_related(
'product_variant__product'
).prefetch_related(
'product_variant__images',
'product_variant__product_attributes__attribute_type'
)
cart_items_ser = OrderItemSerailzier(
cart_items, many=True, context={'request': request})
product_ser_context = {
'request': request, 'view_type': 'instance', 'cart_items': cart_items_ser.data}
else:
product_ser_context = {'request': request, 'view_type': 'instance'}
product_ser_context = {'request': request, 'view_type': 'instance'}
product_ser = self.serializer_class(instance=product, many=False, context=product_ser_context)
product_ser = self.serializer_class(
instance=product, many=False, context=product_ser_context)
return Response(product_ser.data, status=status.HTTP_200_OK)
@@ -74,6 +104,7 @@ class AllProductsView(APIView):
serializer_class = DynamicProductSerializer
pagination_class = StructurePagination
authentication_classes = []
@extend_schema(
parameters=[
OpenApiParameter(
@@ -95,7 +126,7 @@ class AllProductsView(APIView):
type=OpenApiTypes.STR,
description="slug category (send it with category type)",
required=False,
),
),
# OpenApiParameter(
# name="category_type",
# type=OpenApiTypes.STR,
@@ -165,13 +196,17 @@ class AllProductsView(APIView):
products = ProductModel.objects.all()
if category_slug:
if 'category' not in category_slug:
sub_category = get_object_or_404(SubCategoryModel, slug=category_slug)
products = ProductModel.objects.filter(category=sub_category)
if 'category' not in category_slug:
sub_category = get_object_or_404(
SubCategoryModel, slug=category_slug)
products = ProductModel.objects.filter(
category=sub_category)
else:
main_category = get_object_or_404(MainCategoryModel, slug=category_slug)
main_category = get_object_or_404(
MainCategoryModel, slug=category_slug)
sub_categories = main_category.subcategorys.all()
products = ProductModel.objects.filter(category__in=sub_categories)
products = ProductModel.objects.filter(
category__in=sub_categories)
in_stock = request.query_params.get('in_stock')
if in_stock is not None:
if in_stock.lower() == 'true':
@@ -190,13 +225,15 @@ class AllProductsView(APIView):
# Search filter
search_query = request.query_params.get('search')
if search_query:
products = products.filter(Q(name__icontains=search_query) | Q(description__icontains=search_query))
products = products.filter(Q(name__icontains=search_query) | Q(
description__icontains=search_query))
# Price filters
price_gte = request.query_params.get('price_gte')
price_lte = request.query_params.get('price_lte')
products = products.annotate(min_price=Min('variants__price'), max_price=Max('variants__price'))
products = products.annotate(min_price=Min(
'variants__price'), max_price=Max('variants__price'))
if price_gte:
try:
@@ -235,21 +272,23 @@ class AllProductsView(APIView):
except SubCategoryModel.DoesNotExist:
return Response({"detail": "Sub Category not found."}, status=status.HTTP_404_NOT_FOUND)
class ShowCaseCategoryListView(APIView):
serializer_class = ShowCaseSliderSerialzier
permission_classes = [AllowAny]
def get(self, request):
categoryes = ShowCaseSlider.objects.all()
categoryes_ser = self.serializer_class(instance=categoryes, many=True, context={'request': request})
categoryes_ser = self.serializer_class(
instance=categoryes, many=True, context={'request': request})
return Response(categoryes_ser.data, status=status.HTTP_200_OK)
class ShowCaseProductsView(APIView):
serializer_class = DynamicProductSerializer
pagination_class = StructurePagination
authentication_classes = []
@extend_schema(
parameters=[
OpenApiParameter(
@@ -262,7 +301,7 @@ class ShowCaseProductsView(APIView):
name="slider_category",
type=OpenApiTypes.INT,
required=False,
),
),
OpenApiParameter(
name="price_gte",
description="Filter products with price greater than or equal to this value.",
@@ -329,11 +368,14 @@ class ShowCaseProductsView(APIView):
except ValueError:
return Response({'detail': 'value error category id should be a number'}, status=status.HTTP_400_BAD_REQUEST)
slider_category = get_object_or_404(ShowCaseSlider, pk=category_id)
slider_category = get_object_or_404(
ShowCaseSlider, pk=category_id)
products = ProductModel.objects.filter(variants__slider_category=slider_category).distinct()
products = ProductModel.objects.filter(
variants__slider_category=slider_category).distinct()
else:
products = ProductModel.objects.filter(variants__slider_category__isnull=False).distinct()
products = ProductModel.objects.filter(
variants__slider_category__isnull=False).distinct()
# Filter by stock status if `in_stock` is specified
in_stock = request.query_params.get('in_stock', "false") == 'true'
@@ -341,20 +383,23 @@ class ShowCaseProductsView(APIView):
products = products.filter(variants__in_stock__gt=0)
# Filter by discount if `has_discount` is specified
has_discount = request.query_params.get('has_discount', "false") == 'true'
has_discount = request.query_params.get(
'has_discount', "false") == 'true'
if has_discount:
products = products.filter(variants__discount__gt=0)
# Search filter
search_query = request.query_params.get('search', None)
if search_query:
products = products.filter(Q(name__icontains=search_query) | Q(description__icontains=search_query))
products = products.filter(Q(name__icontains=search_query) | Q(
description__icontains=search_query))
# Price filters
price_gte = request.query_params.get('price_gte', None)
price_lte = request.query_params.get('price_lte', None)
products = products.annotate(min_price=Min('variants__price'), max_price=Max('variants__price'))
products = products.annotate(min_price=Min(
'variants__price'), max_price=Max('variants__price'))
if price_gte:
products = products.filter(max_price__gte=price_gte)
@@ -370,22 +415,19 @@ class ShowCaseProductsView(APIView):
# Pagination
paginator = self.pagination_class()
paginated_products = paginator.paginate_queryset(products, request)
serializer = self.serializer_class(paginated_products, many=True, context={'request': request, 'view_type': 'slider'})
serializer = self.serializer_class(paginated_products, many=True, context={
'request': request, 'view_type': 'slider'})
return paginator.get_paginated_response(serializer.data)
except MainCategoryModel.DoesNotExist:
return Response({"detail": "Category not found."}, status=status.HTTP_404_NOT_FOUND)
class CommentView(APIView):
serializer_class = CommentSerializer
permission_classes = [IsAuthenticatedOrReadOnly]
pagination_class = StructurePagination
@extend_schema(
parameters=[
OpenApiParameter(
@@ -408,10 +450,12 @@ class CommentView(APIView):
)
def get(self, request, slug):
product = get_object_or_404(ProductModel, slug=slug)
comments = product.comments.filter(review_status__in=['not_reviwed', 'reviewed_and_confirmed'])
comments = product.comments.filter(
review_status__in=['not_reviwed', 'reviewed_and_confirmed'])
paginator = self.pagination_class()
paginated_comments = paginator.paginate_queryset(comments, request)
comments_ser = self.serializer_class(instance=paginated_comments, many=True)
comments_ser = self.serializer_class(
instance=paginated_comments, many=True)
return paginator.get_paginated_response(comments_ser.data)
def post(self, request, slug):
@@ -428,23 +472,15 @@ class CommentView(APIView):
comment.delete()
return Response(status=status.HTTP_204_NO_CONTENT)
else:
return Response({"detail": "شما اجازه ی پاک کردن این کامنت را ندارید"}, status=status.HTTP_403_FORBIDDEN)
return Response({"detail": "شما اجازه ی پاک کردن این کامنت را ندارید"}, status=status.HTTP_403_FORBIDDEN)
from rest_framework.response import Response
from rest_framework.views import APIView
from rest_framework import serializers
from .models import ProductModel
class BotProductSerializer(serializers.ModelSerializer):
class Meta:
model = ProductModel
fields = ['pk', 'name']
class BotProductsView(APIView):
serializer_class = BotProductSerializer
@@ -462,7 +498,7 @@ class BotProductsView(APIView):
"success": False,
"products": []
})
class BotProductDetailView(APIView):
def get(self, request, pk):
@@ -470,20 +506,25 @@ class BotProductDetailView(APIView):
return Response({
'name': product.name,
'banner' : product.bot_banner,
'banner': product.bot_banner,
'link': f'https://heymlz.com/product/{product.slug}'
})
class BotCategorySerializer(serializers.ModelSerializer):
link = serializers.SerializerMethodField()
class Meta:
model = MainCategoryModel
fields = ['pk', 'name', 'link']
def get_link(self, obj):
return f'https://heymlz.com/products/category/{obj.slug}'
class BotCategoryView(APIView):
serializer_class = BotCategorySerializer
def get(self, request):
categories = MainCategoryModel.objects.all()
categories_ser = self.serializer_class(categories, many=True)
@@ -497,4 +538,4 @@ class BotCategoryView(APIView):
return Response({
"success": False,
"categories": []
})
})